Consolidate GemfireMessageGroupStore to single region [INT-2064]

[spring-operator]

David Turanski opened INT-2064 and commented

Currently uses 3 regions. Consolidate to one.

---

Affects: 2.1 M1

This issue is a sub-task of #6030

Issue Links:

• Refactor Aggregator and Resequencer to better accommodate full span of use-cases [INT-2152] #6135 Refactor Aggregator and Resequencer to better accommodate full span of use-cases
  ("is superseded by")

[spring-operator]

Oleg Zhurakousky commented

There is a new test that was pushed as part of #6124 effort: https://github.com/olegz/spring-integration/blob/8fbec0ddd7b85278c4deeca4c7333145c7b4897d/spring-integration-gemfire/src/test/java/org/springframework/integration/gemfire/store/GemfireGroupStoreTests.java which contains pretty good coverage of MG functionality and is modeled after Redis and Mongo tests, so now they are all identical

[spring-operator]

David Turanski commented

see #6124

[spring-operator]

Mark Fisher commented

The code in #6124 is still using 2 regions (one for Message instances and one for MessageGroup instances), but I assume that's okay? (just checking since this was closed).

[spring-operator]

Mark Fisher commented

Reopening while awaiting reply on last comment.

[spring-operator]

Oleg Zhurakousky commented

Yeah its okay, since 2 regions are used independently. Basically GemfireMessageStore is both MessageStore and MessageGroupStore and one region is use for MS while another is used for MGS. The problem before was that there was a separate region for MARKED and UNMAEKED; in other words a single Message group was spread between more then one region. It is not the case now

[spring-operator]

Mark Fisher commented

Okay. Then, I guess my only concern is what is mentioned in my comments on #6031.

This one can probably be resolved, but I would prefer not to close any of these until the underlying issue is actually merged into master.

[spring-operator]

Oleg Zhurakousky commented

This has been addressed by #6135