5.3.8 TcpNioClientConnectionFactory.java

[shvo123]

In what version(s) of Spring Integration are you seeing this issue?

For example:

5.3.8.RELEASE

Describe the bug
You corrected TcpNioClientConnectionFactory.java from
it was 50 and you changed it to 5.

	Thread.sleep(5); // NOSONAR Magic #
		connected = socketChannel.finishConnect();
		timeLeft -= 5; //

but it was not ropogated to 5.3.x as patch.

it need it since current connect function causes us substential delay (50 ms per connection)

10x,
David

[artembilan]

Thank you for pointing to this!
We have just added the fix to 5.3.x branch.
Although I wonder what keeps you on that old version?
Why just don't upgrade to the latest one: https://spring.io/projects/spring-integration#learn ?

The point is that we don't have plans to release 5.3.9 at the moment...

[artembilan]

Fixed via: e714f69

[shvo123]

Hi Artem, I tried to migrate to version 5.5.1 however in the new version I have some problems. We are using TcpNetServerConnectionFactory and out of the blue we are getting Tcp events that we do not have in 5.3.8 that causes closing of socket/sockets that should not be affected at all. We can see in the logs message that says: " No publisher available to publish TcpConnectionOpenEvent" from this.logger.warn("No publisher available to publish " + event); 10x, David

…

On Thu, Jul 15, 2021 at 7:18 PM Artem Bilan ***@***.***> wrote: Thank you for pointing to this! We have just added the fix to 5.3.x branch. Although I wonder what keeps you on that old version? Why just don't upgrade to the latest one: https://spring.io/projects/spring-integration#learn ? The point is that we don't have plans to release 5.3.9 at the moment... — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#3589 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACOO3JGKMUK4ACHTEN4QVZDTX4C5ZANCNFSM5ANYRMRQ> .

-- Rgds, David Herschler Shvo

[garyrussell]

No publisher available ...

That message implies that your connection factory is not properly registered as a bean and is not managed by Spring.

That said, I don't see any changes to events except fixing a problem with which thread published the open event. So I don't think the issue has anything to do with events (although you should change the factory to be managed by Sprring). Events don't "cause socket closures" they are simply a way to be notified of them.

We would need more information to determine why you are getting socket closures on the recent versions.

[shvo123]

Hi, I am trying to migrate our software from Spring 5.3.8 to Spring Integration 5.5.2. Somehow, `addNewConnection()` of one of the interceptors that extends `TcpConnectionInterceptorSupport` is not activated upon receiving connection on v5.5.2 while in 5.3.8 it works just perfect. from the 4 interceptors defined for this factory, it is the only one that is not activated. Your advice would be appreciated. ``` <bean id="ctm_listener_connection_interceptors_chain" class="org.springframework.integration.ip.tcp.connection.TcpConnectionInterceptorFactoryChain"> <property name="interceptors"> <array> <bean class="com.bmc.ctm.agent.ar.si.tcp.ConnectionCloseSupportTcpConnectionInterceptorFactory"> <constructor-arg name="router" ref="siid_router"/> <constructor-arg name="persistConnectionStateHolder" ref="persistConnectionStateHolder"/> </bean> <bean id="persistentInterceptorFactory" class="com.bmc.ctm.agent.ar.si.tcp.PersistentModeConnectionInterceptorFactory"> <constructor-arg name="holder" ref="persistConnectionStateHolder"/> <constructor-arg name="tcpConnectionFactory" ref="connectionPostProcessor"/> <constructor-arg name="msgTblBean" ref="msgtbl"/> <constructor-arg name="ctmAuthorizedConnection" ref="authorizedConnection"/> </bean> <bean id="transientInterceptorFactory" class="com.bmc.ctm.agent.ar.si.tcp.TransientModeConnectionInterceptorFactory"> <constructor-arg name="configBean" ref="config"/> <constructor-arg name="tcpConnectionFactory" ref="connectionPostProcessor"/> <constructor-arg name="ctmAuthorizedConnection" ref="authorizedConnection"/> </bean> <bean class="com.bmc.ctm.agent.ar.si.tcp.ConnectionSupportTcpConnectionInterceptorFactory"> <constructor-arg name="sslConfig" ref="serverSslConfigLoader"/> </bean> </array> </property> </bean> ``` 10x, David

[artembilan]

Email replies do not support Markdown

@shvo123 , please, consider to add a comment directly here on GitHub. Otherwise that code snippet is hard to read.

We probably need to know what those your custom interceptors are doing and let's rethink if there is really a strong reason to have so many of them