Skip to content

Conversation

amalinovskiy
Copy link
Contributor

Fixes #167

@pivotal-issuemaster
Copy link

@amalinovskiy Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-issuemaster
Copy link

@amalinovskiy Thank you for signing the Contributor License Agreement!

Copy link
Member

@artembilan artembilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, consider to fix Checkstyle violations:

> Task :checkstyleTest FAILED

[ant:checkstyle] [ERROR] /home/travis/build/spring-projects/spring-integration-aws/src/test/java/org/springframework/integration/aws/inbound/KinesisMessageDrivenChannelAdapterTests.java:21:15: Unused import - org.junit.jupiter.api.Assertions.assertTrue. [UnusedImports]

Run gradlew check instead of test locally.

Thanks

Copy link
Member

@artembilan artembilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh! I got it now:

kinesis handles adding a shard by closing a shard and opening 2 new instead, creating a scenario where it

So, good catch and thank you for contribution.

Merging...

@artembilan artembilan merged commit e0df55a into spring-projects:master Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consumers for new shards are not launched if shard count > concurrency in KinesisMessageDrivenChannelAdapter

3 participants