Skip to content

Use ScrollPosition.offset() to get initial scroll position #839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 18, 2023
Merged

Use ScrollPosition.offset() to get initial scroll position #839

merged 1 commit into from
Oct 18, 2023

Conversation

nilshartmann
Copy link
Contributor

OffsetScrollPosition.initial() is package protected, so I think ScrollPosition.offset() is the right way to create an initial ScrollPosition

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Oct 17, 2023
@rstoyanchev rstoyanchev self-assigned this Oct 18, 2023
@rstoyanchev rstoyanchev added type: documentation A documentation task and removed status: waiting-for-triage An issue we've not yet triaged labels Oct 18, 2023
@rstoyanchev rstoyanchev added this to the 1.2.4 milestone Oct 18, 2023
@rstoyanchev rstoyanchev merged commit 80b1c27 into spring-projects:main Oct 18, 2023
@rstoyanchev
Copy link
Contributor

rstoyanchev commented Oct 18, 2023 •
edited
Loading

Thanks for spotting this. I think the API changed after the docs were written.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rstoyanchev rstoyanchev

Labels
type: documentation A documentation task
Projects
None yet
Milestone
1.2.4
Development

Successfully merging this pull request may close these issues.
3 participants
@nilshartmann @rstoyanchev @spring-projects-issues