SPR-13033: Use @RequestMapping of correct class #799
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MvcUriComponentsBuilder::fromMethodCall creates wrong URLs with derived controller classes. The @RequestMapping of the declaring class of the method that is called is used instead of the @RequstMapping of the given controller class. https://jira.spring.io/browse/SPR-13033
rstoyanchev
added a commit
that referenced
this pull request
May 18, 2015
Contributor
|
This is now merged. I've made sure all method accept a controllerType. The existing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MvcUriComponentsBuilder::fromMethodCallcreates wrong URLs with derived controller classes. The@RequestMappingof the declaring class of the method that is called is used instead of the@RequstMappingof the given controller class.The same issue exists for the
fromMethod(Method method, ...)methods. You'd also need to add the class of the controller to get the correct type level@RequestMapping. I'm not sure how you want to handle such API breaking changes though...https://jira.spring.io/browse/SPR-13033