Add overloads in HtmlUtils to allow for encoding aware behavior. #385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on the encoding, in many cases, many characters do not need to be transformed into entities. For instance, when the encoding is UTF-8, there are only 5 characters that needs to become entities and shouldn't appear in their literal forms. See SPR-9293
Contributor
Author
|
I have signed and agree to the terms of the SpringSource Individual Contributor License Agreement. |
Contributor
Author
bclozel
added a commit
that referenced
this pull request
Oct 21, 2014
This commit adds new htmlEscape methods that take the character encoding as a parameter. According to specs and recommendations, the list of chars to be html escaped depends on the encoding used in the response. If the current char encoding supports chars natively, we shouldn't escape those; of course, reserved chars (<,>,',",&) should always be escaped. See: http://www.w3.org/TR/html4/sgml/entities.html#h-24.3 See: #385 by @candrews Issue: SPR-9293
Member
|
Merged with 369cabf |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the encoding, in many cases, many characters do not need to be transformed into entities.
For instance, when the encoding is UTF-8, there are only 5 characters that needs to become entities
and shouldn't appear in their literal forms.
See SPR-9293