Add more lambda expressions in data-access code examples #24398
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxxedev
commented
Jan 20, 2020
spring-projects-issues
added
the
status: waiting-for-triage
sbrannen
added
type: documentation
sbrannen
requested changes
Feb 4, 2020
sbrannen
added
status: waiting-for-feedback
sbrannen
changed the title
fix typo on resultSet. inline lambda expressions to be consistent with explanatory text. store row mapper as a final field.
Contributor
Author
|
@sbrannen anything else? |
spring-projects-issues
added
status: feedback-provided
Member
Thanks for making the changes. I think that looks pretty good now, and I'll review it locally before merging. |
sbrannen
added a commit
that referenced
this pull request
Mar 17, 2020
Member
Member
|
As a side note, the last Kotlin example in this section still uses a local class instead of a lambda expression. I'll see if we can that addressed as well. |
sbrannen
added a commit
that referenced
this pull request
Mar 18, 2020
Contributor
Author
|
thanks for the review! the newer example may not compile though. |
sbrannen
added a commit
that referenced
this pull request
Mar 22, 2020
This commit fixes the example by reverting the renaming of the local Actor variable to avoid a conflict with a same-named variable already in the current scope. See gh-24398
Member
You're welcome.
Fixed in b52136d. Thanks again for pointing that out! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add more java8 lambda expressions in documentation for data-access