SPR-17458 Documentation explicit Executor usage on @Async section #2009
Conversation
| |=== | ||
|
|
||
| The values in the preceding table are defined as enums on the `RegistrationPolicy` class. | ||
| The values in the preceding table are defined as enums on the `RegistrationPolicy` class. |
There was a problem hiding this comment.
Thanks but that's unrelated to the purpose of the PR. I've fixed that in 8684650
| ==== | ||
| [source,java,indent=0] | ||
| [subs="verbatim,quotes"] | ||
| ---- |
There was a problem hiding this comment.
Explaining how to configure @EnableAsync in a section named "Executor Qualification with @Async" looks odd to me. This is also a copy/paste of the javadoc of @EnableAsync so I am not too keen to duplicate that.
Can we take a step back and can you describe why you'd want this to be added here?
There was a problem hiding this comment.
Sure. The main purpose of this PR is as described on https://jira.spring.io/projects/SPR/issues/SPR-17458 to make more clear where the XML-based 'annotation-driven' element default considered executor is coming from. As also commented here unless there is a way to link directly to the referred task:annotation-driven XML definition (which in my opinion is a better approach), duplicating it in this section is the only other way.
In particular the initial section you are quoting here is indeed not related to the executor usage but I've included it because that's how I've interpreted the last section of the last phrase of the description of the ticket: 'and make sure it refers to annotations'. Unless I got it wrong of course - maybe it means an @Bean Java Config definition of an Executor?
|
Thanks for the feedback. I am not keen to copy/paste the setup instruction there so I've added a link and restructured that section a bit 3232825. Thanks for the PR in any case. |
2 participants
Making more explicit the reference to the Executor usage for
@Async.