StringUtils.getFilename(String) should parse any kind of file separator [SPR-5284]

[spring-projects-issues]

Kengkaj S. opened SPR-5284 and commented

Currently, StringUtils.getFilename(String) code is
[code]path.lastIndexOf(FOLDER_SEPARATOR);[/code]
which FOLDER_SEPARATOR is "/", so it doesn't work with Windows file separator.

---

Affects: 2.5.6

Issue Links:

• CommonsMultipartFile.getOriginalFilename() does not strip file path properly [SPR-13662] #18237 CommonsMultipartFile.getOriginalFilename() does not strip file path properly

[spring-projects-issues]

Rossen Stoyanchev commented

This issue has been resolved through a selective bulk update, as part of a larger effort to better manage unresolved issues. To qualify for the update, the issue was either created before Spring 3.0 or affects a version older than Spring 3.0 and is not a bug.

There is a good chance the request was made obsolete, or at least partly outdated, by changes in later versions of Spring including deprecations. It is also possible it didn't get enough traction or we didn't have enough time to address it. One way or another, we didn't get to it.

If you believe the issue, or some aspects of it, are still relevant and worth pursuing at present you may re-open this issue or create a new one with a more up-to-date description.

We thank you for your contributions and encourage you to become familiar with the current process of managing Spring Framework JIRA issues that has been in use for over a year.

[spring-projects-issues]

alessandro porfiri commented

This still needs a fix, and I have a pull request for it

[spring-projects-issues]

Juergen Hoeller commented

Actually, on review, this is by design: All of the path extraction operations in StringUtils assume Java resource paths with "/" separators, since they are primarily designed for use with Spring's core.io.resource abstraction. It's just cleanPath which turns Windows separators into those canonical resource path separators, to be invoked before applying any other operation.

Juergen