CommonsMultipartFile.getOriginalFilename() should be able to preserve header-specified filename as-is [SPR-14613]

[spring-projects-issues]

Juergen Hoeller opened SPR-14613 and commented

getOriginalFilename() explicitly strips path information from a Commons-FileUpload-given filename in CommonsMultipartFile but just exposes the header-specified filename as-is in StandardMultipartFile.

Let's revisit what's actually necessary in 2016 and whether the behavior needs to be more consistent here.

---

Issue Links:

• CommonsMultipartFile.getOriginalFilename() does not strip file path properly [SPR-13662] #18237 CommonsMultipartFile.getOriginalFilename() does not strip file path properly
• StandardServletMultipartResolver should support MaxUploadSizeExceededException against common servers [SPR-9294] #13932 StandardServletMultipartResolver should support MaxUploadSizeExceededException against common servers
• StandardMultipartFile.transferTo should fall back to manual copy if Part.write doesn't support absolute locations (e.g. on Jetty) [SPR-15257] #19822 StandardMultipartFile.transferTo should fall back to manual copy if Part.write doesn't support absolute locations (e.g. on Jetty)

Referenced from: commits 5115c61, aa29495

1 votes, 2 watchers

[spring-projects-issues]

Juergen Hoeller commented

I've added a corresponding preserveFilename flag to CommonsMultipartResolver (or more specifically a setPreserveFilename(boolean) method to its superclass CommonsFileUploadSupport, passed on to CommonsMultipartFile: Switching that flag to true forces getOriginalFilename() to return the FileItem.getName() result as-is, not artificially stripping off any path information.