Incorrect example in section 9.9.2 [SPR-11318]

[spring-projects-issues]

Jose Luis Martin opened SPR-11318 and commented

Hi all,

At bottom of section 9.9.2 Using metadata-driven auto-proxying there is the following example:

<bean id="lockMixin" class="org.springframework.aop.LockMixin"
        scope="prototype"/>

<bean id="lockableAdvisor" class="org.springframework.aop.support.DefaultPointcutAdvisor"
        scope="prototype">
    <property name="pointcut" ref="myAttributeAwarePointcut"/>
    <property name="advice" ref="lockMixin"/>
</bean>

<bean id="anyBean" class="anyclass" ...

but

• DefaultPoincutAdvisor cannot be used with introductions as don't implements IntroductionAdvisor.
• LockMixin is in test.mixin package.

Best regards

---

Affects: 3.2.6, 4.0 GA

Referenced from: commits 50dfa03

[spring-projects-issues]

Juergen Hoeller commented

I've changed that example to a simple DefaultIntroductionAdvisor, without an extra pointcut in the mix. It's generally recommendable to use a custom DefaultIntroductionAdvisor subclass, as shown with the LockMixinAdvisor earlier.

Juergen

[spring-projects-issues]

Jose Luis Martin commented

Hi Juergen,

About this topic, when adding introductions based on type patterns, We can use something like
\

public class TypePatternIntroductionAdvisor extends DefaultIntroductionAdvisor {

	private TypePatternClassFilter typePatternClassFilter = new TypePatternClassFilter();
	
	public TypePatternIntroductionAdvisor(Advice advice) {
		super(advice);
	}
	
	public void setTypePattern(String typePattern) {
		typePatternClassFilter.setTypePattern(typePattern);
	}

	@Override
	public boolean matches(Class clazz) {
		return typePatternClassFilter.getTypePattern() != null ? typePatternClassFilter.matches(clazz) : true;
	}
}

\
Althought it is a trivial class, Do you think that the framework might include something like this?