Fix SpEL JavaBean compliance for setters [SPR-10122]

[spring-projects-issues]

David Boden opened SPR-10122 and commented

#13761 changed SPEL so that it was in line with the JavaBean specification for attributes with lowercase first letters and uppercase second letters like:

iD
pNDV

Changes were made to: org.springframework.expression.spel.support.ReflectivePropertyAccessor

This method was updated under change #13761, so that it checks the 2nd character in the name as a special case (line 312):

protected Method findGetterForProperty(String propertyName, Class<?> clazz, boolean mustBeStatic)

The corresponding method for setters was not updated (line 344):

protected Method findSetterForProperty(String propertyName, Class<?> clazz, boolean mustBeStatic)

---

Affects: 3.2 GA

Issue Links:

• [SpEL] Problem with uppercase property names [SPR-9123] #13761 [SpEL] Problem with uppercase property names

Referenced from: commits 0ed9cb2, d91a419

1 votes, 4 watchers

[spring-projects-issues]

David Boden commented

Pull request:

#206

[spring-projects-issues]

Sam Brannen commented

Chris Beams, since you handled #13761, perhaps you can take a look at this issue as well.

[spring-projects-issues]

Chris Beams commented

commit d91a419fdc4f520ba8e443e689998f4e7b5a2b2c
Author: Chris Beams <cbeams@vmware.com>
Commit: Chris Beams <cbeams@vmware.com>

    Fix SpEL JavaBean compliance for setters
    
    Prior to this change, SpEL was capable of handling getter methods for
    property names having a lowercase first letter and uppercase second
    letter such as:
    
        public String getiD() { ... }
    
    However, setters with the same naming arrangement were not supported,
    e.g.:
    
        public void setiD() { ... }
    
    This commit ensures that setters and getters are treated by SpEL equally
    in this regard, such that "iD"-style property names may be used anywhere
    within SpEL expressions.
    
    Issue: SPR-10122, SPR-9123

[spring-projects-issues]

David Boden commented

Works well in 3.2.1. Thanks.