DATAJDBC-263 - publish events for @Query annotated methods
#94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schauder
added a commit
that referenced
this pull request
Oct 15, 2018
Improved formatting, added author tags and issue comments. Changed "entity" to "aggregate" in test names to make it more precise. Original pull request: #94.
schauder
added a commit
that referenced
this pull request
Oct 15, 2018
Improved formatting, added author tags and issue comments. Changed "entity" to "aggregate" in test names to make it more precise. Original pull request: #94.
|
I polished and merged it. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That's my first PR to Spring Data JDBC so I hope I got the project right.
This change causes framework to trigger
AfterLoadEventfor all entities loaded using@Queryannotated methods in repositories.Since there is some overlap between publishing events in
JdbcAggregateTemplateandJdbcRepositoryQueryperhaps it's a good idea to extract something likeEntityEventPublisherthat would have access toRelationalMappingContext.