DATAJDBC-252 - Properties only get set if they are not part of the constructor. #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nstructor. For mutable entities this avoids superfluous setting of attributes. For imutables without "Wither"s this avoids failures due to not being able to set a property.
odrotbohm
requested changes
Aug 20, 2018
| @@ -73,8 +74,14 @@ public T mapRow(ResultSet resultSet, int rowNumber) { | |||
|
|
|||
| Object id = idProperty == null ? null : readFrom(resultSet, idProperty, ""); | |||
|
|
|||
| PreferredConstructor<T, RelationalPersistentProperty> persistenceConstructor = entity.getPersistenceConstructor(); | |||
There was a problem hiding this comment.
We should avoid the iteration over the properties entirely by returning the just created instance if PersistentEntity.requiresPropertyPopulation() is false.
… all. This avoids needless iterating over the properties for instances fully constructed by their constructor.
…ete constructors correctly.
odrotbohm
pushed a commit
that referenced
this pull request
Aug 21, 2018
…ted. The entity creation not skips the property population entirely if the metamodel indicates that the instantiation already creates a complete entity. If there's need to actively populate properties, we now correctly skip the ones already consumed by the constructor. Original pull request: #86.
mp911de
pushed a commit
that referenced
this pull request
Feb 21, 2022
Convert idents to tabs. Fix Kotlin extensions formatting. Original pull request: #86.
mp911de
added a commit
that referenced
this pull request
Feb 21, 2022
Remove unused imports. Original pull request: #86.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For mutable entities this avoids superfluous setting of attributes.
For imutables without "Wither"s this avoids failures due to not being able to set a property.