Skip to content

Do not override existing limit in selectOne. #1233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Do not override existing limit in selectOne. #1233

wants to merge 3 commits into from

Conversation

RobertHeim
Copy link
Contributor

Closes spring-projects/spring-data-r2dbc#758

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

@RobertHeim RobertHeim mentioned this pull request Apr 27, 2022
Closed
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 27, 2022
@mp911de mp911de added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Apr 29, 2022
@mp911de mp911de self-assigned this Apr 29, 2022
@mp911de mp911de closed this in 76ed7e2 Apr 29, 2022
mp911de added a commit that referenced this pull request Apr 29, 2022
@mp911de
Polishing.
f6e7792 
Introduce Query.isLimited method to avoid magic numbers.

See #1233
Original pull request: #1233.
@mp911de
Copy link
Member

mp911de commented Apr 29, 2022

Thank you for your contribution. That's merged, polished, and backported to Spring Data R2DBC now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mp911de mp911de

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
3.0 M4 (2022.0.0)
Development

Successfully merging this pull request may close these issues.

Override query limit in R2dbcEntityTemplate.selectOne only if the query has no limit
3 participants
@RobertHeim @mp911de @spring-projects-issues