-
Couldn't load subscription status.
- Fork 1.2k
Add support for Redis SINTERCARD command #3210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Redis SINTERCARD command #3210
Conversation
Signed-off-by: Kiminni <[email protected]>
Signed-off-by: Kiminni <[email protected]>
Signed-off-by: Kiminni <[email protected]>
Signed-off-by: Kiminni <[email protected]>
…etCommands Signed-off-by: Kiminni <[email protected]>
…nsIntegrationTests Signed-off-by: Kiminni <[email protected]>
ac54149 to
4fc1965
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the excellent contribution @Kiminni.
I believe there are still a few places to add the new API to:
RedisSet/DefaultRedisSet/DefaultRedisZSetBoundSetOperations- the Reactive counterparts
src/main/java/org/springframework/data/redis/connection/RedisSetCommands.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Kiminni <[email protected]>
Signed-off-by: Kiminni <[email protected]>
Signed-off-by: Kiminni <[email protected]>
…OperationsIntegrationTests Signed-off-by: Kiminni <[email protected]>
Signed-off-by: Kiminni <[email protected]>
Signed-off-by: Kiminni <[email protected]>
|
Hello, @onobc. I’ve applied the requested changes and addressed the review feedback. Thank you! |
This commit adds support for Redis 7.0+ SINTERCARD command in Spring Data Redis. The `sInterCard` API has been added to SetCommands and ClusterSetCommands for both Jedis and Lettuce. The high-level `intersectSize` API has been added to SetOperations implementations as well. Original Pull Request: #3210 Resolves: #2906 Signed-off-by: Kiminni <[email protected]>
Summary
Implements support for Redis 7.0+ SINTERCARD command in Spring Data Redis.
Fixes #2906
Changes
Core Implementation
sInterCardmethod toRedisSetCommandsinterfacesInterCardinJedisSetCommandsusing Jedis clientsInterCardinLettuceSetCommandsusing Lettuce clientCluster Support
sInterCardinJedisClusterSetCommandssInterCardinLettuceClusterSetCommandsConnection Wrappers
sInterCarddelegation inDefaultedRedisConnectionsInterCardsupport inStringRedisConnectionDefaultStringRedisConnectionHigh-Level API
intersectSizemethods toSetOperationsintersectSizeinDefaultSetOperationsTesting
Comprehensive integration tests with
@EnabledOnCommand("SINTERCARD")Test coverage for all connection types (Jedis, Lettuce, Cluster)
Various intersection scenarios (empty, partial, full)
You have read the Spring Data contribution guidelines.
You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
You submit test cases (unit or integration tests) that back your changes.
You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).