Skip to content

Fix NPE in RequestFactory when language in UpdateQuery is not set (4.4.x) #2288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 3, 2022
Merged

Fix NPE in RequestFactory when language in UpdateQuery is not set (4.4.x) #2288

merged 1 commit into from
Sep 3, 2022

Conversation

sothawo
Copy link
Collaborator

@sothawo sothawo commented Sep 3, 2022

Closes #2287

@sothawo sothawo merged commit 988736d into spring-projects:4.4.x Sep 3, 2022
@sothawo sothawo mentioned this pull request Sep 3, 2022
Closed
@sothawo sothawo linked an issue Sep 3, 2022 that may be closed by this pull request
Fix NPE in RequestFactory when language in UpdateQuery is not set (4.4.x). #2287
Closed
sothawo added a commit that referenced this pull request Sep 3, 2022
@sothawo
Fix NPE in RequestFactory when language in UpdateQuery is not set (4.…
77da225 
…4.x).

Original Pull Request #2288
Closes #2287

(cherry picked from commit 988736d)
@sothawo sothawo deleted the #2287-fix-requestfactrory-npe branch September 3, 2022 08:20
@37176427
Copy link

37176427 commented Apr 25, 2023 •
edited
Loading

I found the same problem in the updateByQuery:
version:4.4.10

code:

UpdateQuery updateQuery = UpdateQuery.builder(query).withScriptedUpsert(true).withScriptType(ScriptType.INLINE).withScript(script).build();
//not set lang,trigger npe
            elasticsearchRestTemplate.updateByQuery(updateQuery, index);

requestFactory.updateByQueryRequest(query, index);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix NPE in RequestFactory when language in UpdateQuery is not set (4.4.x).
2 participants
@sothawo @37176427