Skip to content

Conversation

SkyAndyToone
Copy link
Contributor

@SkyAndyToone SkyAndyToone commented Mar 2, 2023

DynamicProxyable repositories can overwrite PseudoArgs object.

When DynamicProxyable repositories are used in heavily concurrent environments, the ReactiveCouchbaseTemplate can overwrite the PseudoArgs object, resulting in null scope, collection and options values. This causes queries to fail unpredictably.

Closes #1684.

@pivotal-cla
Copy link

@SkyAndyToone Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-cla
Copy link

@SkyAndyToone Thank you for signing the Contributor License Agreement!

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 2, 2023
Copy link
Collaborator

@mikereiche mikereiche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@mikereiche mikereiche merged commit 9539013 into spring-projects:main Mar 7, 2023
mikereiche pushed a commit that referenced this pull request Mar 7, 2023
* ReactiveCouchbaseTemplate can overwrite PseudoArgs under heavy concurrency.

Raised as issue #1684

* Added author
mikereiche pushed a commit that referenced this pull request Apr 25, 2023
* ReactiveCouchbaseTemplate can overwrite PseudoArgs under heavy concurrency.

Raised as issue #1684

* Added author
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: waiting-for-triage An issue we've not yet triaged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ReactiveCouchbaseTemplate can overwrite PseudoArgs under heavy concurrency.

4 participants