Skip to content

Fix arrayContaining n1ql generated. #1548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 26, 2022
Merged

Fix arrayContaining n1ql generated. #1548

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...-couchbase/src/main/java/org/springframework/data/couchbase/core/query/QueryCriteria.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,12 +331,12 @@ public QueryCriteria arrayContaining(@Nullable Object o) {
}

public QueryCriteria arrayContaining(boolean ignoreCase, @Nullable Object o) {
operator = "array_containing";
operator = "array_contains";
if (ignoreCase) {
throw new CouchbaseException("ignoreCase not supported in IN and NOT_IN");
}
value = new Object[] { o };
format = "array_containing(%1$s, %3$s)";
format = "array_contains(%1$s, %3$s)";
return this;
}

Expand Down
5 changes: 5 additions & 0 deletions .../java/org/springframework/data/couchbase/core/CouchbaseTemplateQueryIntegrationTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,11 @@ void findByMatchingQuery() {
.matching(specialUsers).all();

assertEquals(1, foundUsers.size());

Query arrayContaining = new Query(QueryCriteria.where(i("firstname")).arrayContaining("not_match_anything"));
final List<User> foundArrayContaining = couchbaseTemplate.findByQuery(User.class).withConsistency(REQUEST_PLUS)
.matching(arrayContaining).all();
assertEquals(0, foundArrayContaining.size());
}

@Test
Expand Down
2 changes: 1 addition & 1 deletion ...hbase/src/test/java/org/springframework/data/couchbase/core/query/QueryCriteriaTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ void testNotContaining() {
@Test
void testArrayContaining() {
QueryCriteria c = where(i("name")).arrayContaining("Elvis");
assertEquals("array_containing(`name`, \"Elvis\")", c.export());
assertEquals("array_contains(`name`, \"Elvis\")", c.export());
}

@Test
Expand Down