Skip to content

Log exceptions thrown from events. #1187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 16, 2021
Merged

Log exceptions thrown from events. #1187

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions src/main/java/org/springframework/data/couchbase/core/CouchbaseTemplateSupport.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ public void maybeEmitEvent(CouchbaseMappingEvent<?> event) {
try {
this.applicationContext.publishEvent(event);
} catch (Exception e) {
e.printStackTrace();
LOG.error("exception emitting event "+event, e);
}
} else {
LOG.info("maybeEmitEvent called, but CouchbaseTemplate not initialized with applicationContext");
Expand All @@ -196,11 +196,7 @@ private boolean canPublishEvent() {

protected <T> T maybeCallBeforeConvert(T object, String collection) {
if (entityCallbacks != null) {
try {
return entityCallbacks.callback(BeforeConvertCallback.class, object, collection);
} catch (Exception e) {
e.printStackTrace();
}
return entityCallbacks.callback(BeforeConvertCallback.class, object, collection);
} else {
LOG.info("maybeCallBeforeConvert called, but CouchbaseTemplate not initialized with applicationContext");
}
Expand Down
8 changes: 2 additions & 6 deletions src/main/java/org/springframework/data/couchbase/core/ReactiveCouchbaseTemplateSupport.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ public void maybeEmitEvent(CouchbaseMappingEvent<?> event) {
try {
this.applicationContext.publishEvent(event);
} catch (Exception e) {
e.printStackTrace();
LOG.error("exception emitting event "+event, e);
}
} else {
LOG.info("maybeEmitEvent called, but ReactiveCouchbaseTemplate not initialized with applicationContext");
Expand All @@ -203,11 +203,7 @@ private boolean canPublishEvent() {

protected <T> Mono<T> maybeCallBeforeConvert(T object, String collection) {
if (reactiveEntityCallbacks != null) {
try {
return reactiveEntityCallbacks.callback(ReactiveBeforeConvertCallback.class, object, collection);
} catch (Exception e) {
e.printStackTrace();
}
return reactiveEntityCallbacks.callback(ReactiveBeforeConvertCallback.class, object, collection);
} else {
LOG.info("maybeCallBeforeConvert called, but ReactiveCouchbaseTemplate not initialized with applicationContext");
}
Expand Down