Skip to content

Conversation

mikereiche
Copy link
Collaborator

@mikereiche mikereiche commented Mar 29, 2021

Fix syntax for USE KEYS [ ... ]

Closes #1064.
Original pull request: #1113.

  • You have read the Spring Data contribution guidelines.
  • There is a ticket in the bug tracker for the project in our JIRA.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

Fix syntax for USE KEYS [ ... ]

Closed #1064.
Original pull request: #1112.
@mikereiche mikereiche requested a review from daschl March 29, 2021 20:14
Copy link
Contributor

@daschl daschl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, but the commit msg should say "Closes" and not "Closed" - I think that's a typo

@mikereiche mikereiche merged commit 1e3d504 into master Mar 30, 2021
mikereiche added a commit that referenced this pull request Mar 30, 2021
Fix syntax for USE KEYS [ ... ]

Closes #1064.
Original pull request: #1113.

Co-authored-by: mikereiche <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

N1QLExpression#keys is broken

2 participants