Make JarURLConnection return entry's last modified time from getLastModified(); #9893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…odified(); Refactor buildJarFileUrl(); Fixes spring-projects#9867
spring-projects-issues
added
the
status: waiting-for-triage
wilkinsona
requested changes
Jul 28, 2017
Member
wilkinsona
left a comment
wilkinsona
left a comment
There was a problem hiding this comment.
Thanks very much for opening your first Spring Boot pull request. I've left a couple of comments. Would you mind taking a look?
| spec = spec.substring(0, spec.length() - SEPARATOR.length()); | ||
| } | ||
| if (spec.indexOf(SEPARATOR) == -1) { | ||
| if (!spec.contains(SEPARATOR)) { |
Member
There was a problem hiding this comment.
Could you please revert this part of the change as it's unrelated to the last modified time
| return defaultTime; | ||
| } | ||
| try { | ||
| if (this.jarEntryName.isEmpty()) { |
Member
There was a problem hiding this comment.
This could be moved outside the try and handled in the if above:
if (this.jarFile == null || this.jarEntryName.isEmpty())
wilkinsona
added
priority: normal
type: bug
wilkinsona
approved these changes
Jul 28, 2017
Member
|
Looks good now. Thank you, @yeaxi! |
wilkinsona
pushed a commit
that referenced
this pull request
Jul 28, 2017
wilkinsona
added a commit
that referenced
this pull request
Jul 28, 2017
* gh-9893: Polish "Make JarURLConnection return entry's last modified time" Make JarURLConnection return entry's last modified time
Member
|
Thanks again for the PR. This has been merged into 1.5.x and master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9867
Refactor buildJarFileUrl();