Skip to content

Conversation

@candrews
Copy link
Contributor

Starting with Hibernate 5.2.10, the JPA property hibernate.connection.provider_disables_autocommit
should be set to true when the datasource has autocommit disabled in order to improve performance.

Fixes #9261

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jul 12, 2017
@candrews candrews force-pushed the autocommit branch 3 times, most recently from d2ca5e5 to 76d464f Compare July 12, 2017 20:09
Copy link
Member

@snicoll snicoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@candrews we're not sure if we're going to proceed with this one (see the related issue) but regardless we won't merge that without a test of some sort (no idea how hard it would be to build one).

Starting with Hibernate 5.2.10, the JPA property `hibernate.connection.provider_disables_autocommit`
should be set to true when the datasource has autocommit disabled in order to improve performance.

Fixes spring-projects#9261
@candrews
Copy link
Contributor Author

I've updated this PR addressing the merge conflicts.

I agree that having some tests would be wonderful :)

@snicoll snicoll self-assigned this Oct 17, 2017
snicoll pushed a commit that referenced this pull request Oct 17, 2017
Starting with Hibernate 5.2.10, the JPA property
`hibernate.connection.provider_disables_autocommit` should be set to true
when the datasource has autocommit disabled in order to improve
performance.

See gh-9737
@snicoll snicoll closed this in 22de430 Oct 17, 2017
snicoll added a commit that referenced this pull request Oct 17, 2017
* pr/9737:
  Polish "When pool autocommit is disabled, inform Hibernate"
  When pool autocommit is disabled, inform Hibernate
@snicoll
Copy link
Member

snicoll commented Oct 17, 2017

Merged with a polish commit, thanks for the PR.

I agree that having some tests would be wonderful :)

@candrews it wasn't that hard. Can you please review 22de430?

@rimal
Copy link

rimal commented Feb 23, 2018

Hey, can you please help me the release in which this will be available?

@wilkinsona
Copy link
Member

It’s in 2.0 M6 and later

@snicoll
Copy link
Member

snicoll commented Feb 23, 2018

@rimal there is a milestone in the upper right corner of this page (unless you're watching this on mobile).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: enhancement A general enhancement

Projects

None yet

6 participants