Skip to content

Deprecate JsonContent.assertThat method to discourage accidental use #9678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Deprecate JsonContent.assertThat method to discourage accidental use #9678

wants to merge 2 commits into from

Conversation

@priyanshi93
Copy link

@priyanshi93 priyanshi93 commented Jul 4, 2017

Resolved issue #9519
Deprecate JsonContent.assertThat method

@pivotal-issuemaster
Copy link

pivotal-issuemaster commented Jul 4, 2017

@Blossoms Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jul 4, 2017
@pivotal-issuemaster
Copy link

pivotal-issuemaster commented Jul 4, 2017

@Blossoms Thank you for signing the Contributor License Agreement!

1 similar comment
@pivotal-issuemaster
Copy link

pivotal-issuemaster commented Jul 4, 2017

@Blossoms Thank you for signing the Contributor License Agreement!

@philwebb
Copy link
Member

philwebb commented Jul 5, 2017

Thanks for the PR. I think we also need some Javadoc to explain what the preferred way of calling the method is.

@philwebb philwebb added the status: waiting-for-feedback We need additional information before we can continue label Jul 5, 2017
@priyanshi93
Copy link
Author

priyanshi93 commented Jul 6, 2017

Hi Philwebb, Thanks for review. This is my first commit and starting up on this.
Please guide me what should be the content of javadoc.
We have deprecated this function to discourage its use as we have other function with same functionality.

@philwebb
Copy link
Member

philwebb commented Jul 6, 2017 •
edited
Loading

Probably something like use {@link org.assertj.core.api.Assertions#assertThat AspectJ's assertThat} instead

@philwebb philwebb mentioned this pull request Jul 6, 2017
Closed
@philwebb philwebb added priority: normal type: enhancement A general enhancement and removed status: waiting-for-feedback We need additional information before we can continue status: waiting-for-triage An issue we've not yet triaged labels Jul 6, 2017
@philwebb philwebb added this to the 2.0.0.M3 milestone Jul 6, 2017
@wilkinsona
Copy link
Member

wilkinsona commented Jul 22, 2017

@philwebb Shouldn't we deprecate this in 1.5.x and remove it in 2.0?

@wilkinsona wilkinsona added status: on-hold We can't start working on this issue yet for: team-attention An issue we'd like other members of the team to review labels Jul 22, 2017
@wilkinsona
Copy link
Member

wilkinsona commented Jul 22, 2017

Ignore the remove it part, I was being daft. I still wonder if we should add the deprecation in 1.5 though.

@wilkinsona wilkinsona modified the milestones: 2.0.0.M3, 2.0.0.M4 Jul 26, 2017
@philwebb philwebb modified the milestones: 1.5.7, 2.0.0.M4 Jul 26, 2017
@philwebb
Copy link
Member

philwebb commented Jul 26, 2017

Yeah, 1.5 makes sense. I've changed the milestone target.

@wilkinsona wilkinsona removed for: team-attention An issue we'd like other members of the team to review status: on-hold We can't start working on this issue yet labels Jul 26, 2017
@wilkinsona wilkinsona self-assigned this Jul 27, 2017
wilkinsona pushed a commit that referenced this pull request Jul 27, 2017
@wilkinsona
Deprecate JsonContent.assertThat()
fa57491 
See gh-9678
wilkinsona added a commit that referenced this pull request Jul 27, 2017
@wilkinsona
Merge pull request #9678 from Priyanshi Goyal
b190a07 
* gh-9678:
  Polish "Deprecate JsonContent.assertThat()"
  Deprecate JsonContent.assertThat()
@wilkinsona
Copy link
Member

wilkinsona commented Jul 27, 2017

@Blossoms Thank you for your first contribution to Spring Boot. I've merged your changes into 1.5.x and master.

@wilkinsona wilkinsona changed the title Bug fix -9519 Deprecate JsonContent.assertThat method Deprecate JsonContent.assertThat method to discourage accidental use Jul 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@wilkinsona wilkinsona

Labels

type: enhancement A general enhancement

Projects

None yet

Milestone

1.5.7

Development

Successfully merging this pull request may close these issues.

5 participants

@priyanshi93 @pivotal-issuemaster @philwebb @wilkinsona @spring-projects-issues