Skip to content

Conversation

@hdohlmann
Copy link

Allow configuration of the dateformat in the logging pattern.
No longer need to provide full logging.pattern.console and logging.pattern.file when the only change needed is the pattern for the dateformat.
Modeled after logging.pattern.level.

In #8506 was suggested logging.dateformat. This has been changed to logging.pattern.dateformat to better fit with the existing logging.pattern.* properties.

Fixes gh-8506

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 7, 2017
@philwebb philwebb added priority: normal type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Mar 14, 2017
@philwebb philwebb added this to the 2.0.0.M1 milestone Mar 14, 2017
@philwebb philwebb added the for: team-attention An issue we'd like other members of the team to review label Mar 14, 2017
@snicoll snicoll removed the for: team-attention An issue we'd like other members of the team to review label Apr 12, 2017
@philwebb
Copy link
Member

We're considering the impact of this changes vs the likelihood that people will need to deviate from the default date/time format. Out of interest what made you need to change from the default format?

@philwebb philwebb added the status: waiting-for-feedback We need additional information before we can continue label Apr 15, 2017
@hdohlmann
Copy link
Author

We gather logs from different countries and need timezone information on the dateformat to properly correlate them

@wilkinsona wilkinsona added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels May 5, 2017
@philwebb philwebb modified the milestones: 2.0.0.M1, 2.0.0.M2 May 16, 2017
@snicoll snicoll modified the milestones: 2.0.0.M2, 2.0.0.M3 Jun 16, 2017
@wilkinsona wilkinsona modified the milestones: 2.0.0.M3, 2.0.0.M4 Jul 26, 2017
@snicoll snicoll modified the milestones: 2.0.0.M4, 2.0.0.M5 Aug 23, 2017
@snicoll snicoll modified the milestones: 2.0.0.M5, 2.0.0.M4 Aug 23, 2017
@philwebb philwebb modified the milestones: 2.0.0.M5, 2.0.0.RC1, 2.0.0.M6 Sep 20, 2017
philwebb pushed a commit to philwebb/spring-boot that referenced this pull request Nov 3, 2017
Add configurable logger dateformat support for Logback and Log4j2.

Closes spring-projectsgh-8516
philwebb added a commit to philwebb/spring-boot that referenced this pull request Nov 3, 2017
…n-dateformat

* pr/8516:
  Introduce configurable logging.pattern.dateformat
@philwebb philwebb closed this in 7728f8f Nov 3, 2017
philwebb added a commit that referenced this pull request Nov 3, 2017
* pr/8516:
  Introduce configurable logging.pattern.dateformat
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: feedback-provided Feedback has been provided type: enhancement A general enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants