Add FONTS location to StaticResourceLocation #46208
Open
+7
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahabkondri
force-pushed
the
add-fonts-static-resource
branch
from
c0a0954 to
5804658
Compare
spring-projects-issues
added
the
status: waiting-for-triage
shahabkondri
changed the title
FONTS location to StaticResourceLocation
shahabkondri
force-pushed
the
add-fonts-static-resource
branch
from
5804658 to
67ecb4e
Compare
philwebb
added
the
for: team-meeting
Signed-off-by: Shahab Kondri <[email protected]>
shahabkondri
force-pushed
the
add-fonts-static-resource
branch
from
67ecb4e to
e1692a9
Compare
philwebb
added
type: enhancement
snicoll
added
the
for: team-meeting
|
We discussed this again today. The issue is noteworthy as we want to call out that this change will affect access to |
wilkinsona
removed
the
for: team-meeting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
StaticResourceLocationhandles common static assets (CSS,JS,IMAGES, …) but omits web-fonts.As a result,
PathRequest.toStaticResources()does not match/fonts/**, forcing users to add custom ant matchers.Adding a dedicated
FONTSlocation ("/fonts/**") removes that gap.Implementation
FONTS("/fonts/**")inStaticResourceLocation.No breaking changes; existing constants keep the same semantics.
Tests
StaticResourceLocationnow matches a/fonts/font.woff2request.