Skip to content

Setting spring.netty.leak-detection has no effect when lazy initialization is enabled #46164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Setting spring.netty.leak-detection has no effect when lazy initialization is enabled #46164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions ...re/src/main/java/org/springframework/boot/autoconfigure/netty/NettyAutoConfiguration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,12 @@
import io.netty.util.NettyRuntime;
import io.netty.util.ResourceLeakDetector;

import org.springframework.boot.LazyInitializationExcludeFilter;
import org.springframework.boot.autoconfigure.AutoConfiguration;
import org.springframework.boot.autoconfigure.EnableAutoConfiguration;
import org.springframework.boot.autoconfigure.condition.ConditionalOnClass;
import org.springframework.boot.context.properties.EnableConfigurationProperties;
import org.springframework.context.annotation.Bean;

/**
* {@link EnableAutoConfiguration Auto-configuration} for Netty.
Expand All @@ -42,4 +44,9 @@ public NettyAutoConfiguration(NettyProperties properties) {
}
}

@Bean
static LazyInitializationExcludeFilter nettyAutoConfigurationLazyInitializationExcludeFilter() {
return LazyInitializationExcludeFilter.forBeanTypes(NettyAutoConfiguration.class);
}

}
25 changes: 20 additions & 5 deletions ...c/test/java/org/springframework/boot/autoconfigure/netty/NettyAutoConfigurationTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,10 @@
package org.springframework.boot.autoconfigure.netty;

import io.netty.util.ResourceLeakDetector;
import org.junit.jupiter.api.AfterEach;
import org.junit.jupiter.api.Test;

import org.springframework.boot.LazyInitializationBeanFactoryPostProcessor;
import org.springframework.boot.autoconfigure.AutoConfigurations;
import org.springframework.boot.test.context.runner.ApplicationContextRunner;

Expand All @@ -34,13 +36,26 @@ class NettyAutoConfigurationTests {
private final ApplicationContextRunner contextRunner = new ApplicationContextRunner()
.withConfiguration(AutoConfigurations.of(NettyAutoConfiguration.class));

@AfterEach
void resetResourceLeakDetector() {
ResourceLeakDetector.setLevel(ResourceLeakDetector.Level.DISABLED);
}

@Test
void leakDetectionShouldBeConfigured() {
this.contextRunner.withPropertyValues("spring.netty.leak-detection=paranoid").run((context) -> {
assertThat(ResourceLeakDetector.getLevel()).isEqualTo(ResourceLeakDetector.Level.PARANOID);
// reset configuration for the following tests.
ResourceLeakDetector.setLevel(ResourceLeakDetector.Level.DISABLED);
});
this.contextRunner.withPropertyValues("spring.netty.leak-detection=paranoid")
.run((context) -> assertThat(ResourceLeakDetector.getLevel())
.isEqualTo(ResourceLeakDetector.Level.PARANOID));
}

@Test
void leakDetectionShouldBeConfiguredWhenLazyInitializationIsEnabled() {
this.contextRunner
.withInitializer(
(context) -> context.addBeanFactoryPostProcessor(new LazyInitializationBeanFactoryPostProcessor()))
.withPropertyValues("spring.netty.leak-detection=advanced")
.run((context) -> assertThat(ResourceLeakDetector.getLevel())
.isEqualTo(ResourceLeakDetector.Level.ADVANCED));
}

}