Skip to content

Conversation

quaff
Copy link
Contributor

@quaff quaff commented Mar 18, 2025

It's not actually necessary, but it's better to align with @DefaultValue.

See #29010

It's not actually necessary, but it's better to align with `@DefaultValue`.

See spring-projects#29010

Signed-off-by: Yanming Zhou <[email protected]>
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 18, 2025
@wilkinsona wilkinsona added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Mar 18, 2025
@wilkinsona wilkinsona added this to the 3.5.x milestone Mar 18, 2025
@wilkinsona wilkinsona added the for: merge-with-amendments Needs some changes when we merge label Mar 18, 2025
@wilkinsona wilkinsona self-assigned this Mar 18, 2025
@wilkinsona wilkinsona added status: declined A suggestion or change that we don't feel we should currently apply and removed type: enhancement A general enhancement for: merge-with-amendments Needs some changes when we merge labels Mar 18, 2025
@wilkinsona wilkinsona removed this from the 3.5.x milestone Mar 18, 2025
@wilkinsona
Copy link
Member

Thanks for the PR, but I don't think we should do this. We made a mistake in #29010 as described in this comment and aligning @Name with @DefaultValue would be a step in the wrong direction. I'm not sure we ever actually discussed removing RECORD_COMPONENT from @DefaultValue. I have labelled it for discussion now.

@wilkinsona wilkinsona closed this Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: declined A suggestion or change that we don't feel we should currently apply

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants