Skip to content

Conversation

nosan
Copy link
Contributor

@nosan nosan commented Feb 18, 2025

Fixes build on Windows

see #44305

ArgFile should not be used when compiling sources via JavaCompiler.

[CreateProcess error=206, The filename or extension is too long]

This happens only when running a process via ProcessBuilder but not JavaCompiler.

@nosan
Copy link
Contributor Author

nosan commented Feb 18, 2025

My apologies, @snicoll.
I don't know how I overlooked this.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 18, 2025
@philwebb
Copy link
Member

Thanks @nosan, I was trying to look at this but it's taken me all day to get a Windows box installed!

@philwebb philwebb added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged labels Feb 18, 2025
@philwebb philwebb added this to the 3.3.x milestone Feb 18, 2025
@nosan
Copy link
Contributor Author

nosan commented Feb 18, 2025

I've installed VMware Fusion. Works perfectly :)

@philwebb philwebb modified the milestones: 3.3.x, 3.3.9 Feb 18, 2025
philwebb pushed a commit that referenced this pull request Feb 18, 2025
@philwebb philwebb closed this in 9dff6cd Feb 18, 2025
@snicoll
Copy link
Member

snicoll commented Feb 19, 2025

There's no need for an apology @nosan. That's part of the review process and it's always tricky with limited access to a windows box. I like the toString() trick very much, good call 👍.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task A general task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants