-
Notifications
You must be signed in to change notification settings - Fork 41.5k
Allow configuring WebDriver with TestNG #27947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Should I add javadoc |
When they were made public, please. |
@cdalexndr Thanks for the pull request. Unfortunately, we can't merge this until we understand why it's needed so that we can justify increasing the surface area of our public API. As @philwebb requested, can you please provide a sample for #27921? |
1ca278f
to
902dd0b
Compare
We have a sample so I don't think we're waiting for feedback. |
We made changes in the past – such as these – in support of TestNG. 3.0 gives us an opportunity to decide if supporting TestNG is something with which we want to continue. |
Accessible webdriver test execution listener for testng:
@TestExecutionListeners({WebDriverTestExecutionListener.class})
Access
WebDriverScope.NAME
outside package to be used by user webdriver implementations. Needs matching name to be picked up by autoconfiguration.See #27921