Skip to content

Conversation

cdalexndr
Copy link
Contributor

Accessible webdriver test execution listener for testng:
@TestExecutionListeners({WebDriverTestExecutionListener.class})

Access WebDriverScope.NAME outside package to be used by user webdriver implementations. Needs matching name to be picked up by autoconfiguration.

@Bean(name = WebDriverScope.NAME)
public WebDriver customWebDriver() {...

See #27921

@cdalexndr cdalexndr changed the title WebDriver manual usage WebDriver custom config Sep 12, 2021
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Sep 12, 2021
@cdalexndr cdalexndr changed the title WebDriver custom config Allow WebDriver custom config Sep 12, 2021
@cdalexndr
Copy link
Contributor Author

cdalexndr commented Sep 12, 2021

Should I add javadoc @since when the feature was originally created, or current version when I made them public?

@wilkinsona
Copy link
Member

When they were made public, please.

@wilkinsona
Copy link
Member

@cdalexndr Thanks for the pull request. Unfortunately, we can't merge this until we understand why it's needed so that we can justify increasing the surface area of our public API. As @philwebb requested, can you please provide a sample for #27921?

@wilkinsona wilkinsona added status: waiting-for-feedback We need additional information before we can continue status: on-hold We can't start working on this issue yet labels Sep 30, 2021
@snicoll snicoll removed status: waiting-for-feedback We need additional information before we can continue status: on-hold We can't start working on this issue yet labels Oct 5, 2021
@philwebb philwebb force-pushed the main branch 3 times, most recently from 1ca278f to 902dd0b Compare November 19, 2021 20:17
@snicoll snicoll changed the title Allow WebDriver custom config Allow configuring WebDriver with TestNG Dec 9, 2021
@scottfrederick scottfrederick added the status: waiting-for-feedback We need additional information before we can continue label May 2, 2022
@wilkinsona
Copy link
Member

We have a sample so I don't think we're waiting for feedback.

@wilkinsona wilkinsona removed the status: waiting-for-feedback We need additional information before we can continue label May 27, 2022
@wilkinsona
Copy link
Member

We made changes in the past – such as these – in support of TestNG. 3.0 gives us an opportunity to decide if supporting TestNG is something with which we want to continue.

@wilkinsona wilkinsona added the for: team-meeting An issue we'd like to discuss as a team to make progress label May 27, 2022
@bclozel bclozel added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged for: team-meeting An issue we'd like to discuss as a team to make progress labels Jun 8, 2022
@bclozel bclozel added this to the 3.0.x milestone Jun 8, 2022
@snicoll snicoll modified the milestones: 3.0.x, 3.0.0-M4 Jun 19, 2022
@snicoll snicoll self-assigned this Jun 19, 2022
snicoll pushed a commit that referenced this pull request Jun 19, 2022
snicoll added a commit that referenced this pull request Jun 19, 2022
@snicoll snicoll closed this in f1631c9 Jun 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants