Keystore.load calls do not close InputStream #25884
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alex-bel-apica Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
spring-projects-issues
added
the
status: waiting-for-triage
philwebb
added
type: bug
|
@alex-bel-apica Thank you for signing the Contributor License Agreement! |
snicoll
changed the title
snicoll
pushed a commit
that referenced
this pull request
Apr 8, 2021
snicoll
added a commit
that referenced
this pull request
Apr 8, 2021
|
@alex-bel-apica thank you for making your first contribution to Spring Boot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that Java process keeps lock on the keystore file when Netty+SSL is used on Windows.
Detailed investigation shown that it happens because InputStream is not closed after keystore is loaded from it.
This PR fixes the issue described above. I also found similar code in other places and fixed it as well.