Skip to content

Conversation

robert-smith-911
Copy link
Contributor

A documentation fix for #25473 to document how to configure maven's failsafe plugin when not using spring boot starter parent pom.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 15, 2021
@snicoll snicoll changed the title Feature/document how to configure maven's failsafe plugin when not using spring boot starter parent #25473 Document how to configure Maven's Failsafe plugin when not using spring-boot-starter-parent Mar 15, 2021
@snicoll snicoll added type: documentation A documentation update and removed status: waiting-for-triage An issue we've not yet triaged labels Mar 15, 2021
@snicoll snicoll added this to the 2.3.x milestone Mar 15, 2021
@wilkinsona
Copy link
Member

wilkinsona commented Mar 15, 2021

Thanks for the pull request, @robert-smith-911. Unfortunately, this isn't quite what I had in mind. Rather than changing the configuration of spring-boot-maven-plugin, I think we should document the same setup as spring-boot-starter-parent gives you. It configures Failsafe to use the compiled classes rather than the repackaged jar:

<plugin>
    <groupId>org.apache.maven.plugins</groupId>
    <artifactId>maven-failsafe-plugin</artifactId>
    <configuration>
        <classesDirectory>${project.build.outputDirectory}</classesDirectory>
    </configuration>
</plugin>

AFAIK, using this approach also means that there's no custom configuration required when the module path's in the picture.

Would you like to update your proposal along these lines?

@wilkinsona wilkinsona added the status: waiting-for-feedback We need additional information before we can continue label Mar 15, 2021
@robert-smith-911
Copy link
Contributor Author

Aha sure @wilkinsona no problem!

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Mar 15, 2021
@snicoll
Copy link
Member

snicoll commented Mar 24, 2021

@robert-smith-911 how is it going? Would you have time to update this PR?

@robert-smith-911
Copy link
Contributor Author

@snicoll Yes sir just got busy at work, doing it today thanks for the reminder

@robert-smith-911
Copy link
Contributor Author

@snicoll @wilkinsona How's this?

@wilkinsona
Copy link
Member

Thanks very much, @robert-smith-911. If you're interested a polished the proposed changes a little bit, primarily to move the updates into the integration testing section of the documentation.

@robert-smith-911
Copy link
Contributor Author

@wilkinsona sure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation A documentation update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants