Skip to content

Conversation

Jurrie
Copy link
Contributor

@Jurrie Jurrie commented Mar 10, 2021

Support reproducable builds for WAR repackaging.

The Maven WAR plugin was fixed by MWAR-432 and MWAR-436. This has landed in version 3.3.1. Spring Boot already uses this version as of a35073d. So, this pull request is just a revert of c4a55a5.

@pivotal-issuemaster
Copy link

@Jurrie Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 10, 2021
@pivotal-issuemaster
Copy link

@Jurrie Thank you for signing the Contributor License Agreement!

@Jurrie
Copy link
Contributor Author

Jurrie commented Mar 10, 2021

I did not actually test this with a Maven project yet. I can not get my Maven project to work with 2.5.0-SNAPSHOT.

I installed this in my local Maven repository using ./gradlew publishToMavenLocal -b spring-boot-project/spring-boot-tools/spring-boot-maven-plugin/build.gradle. When I run my Maven project, it uses 2.5.0-SNAPSHOT, but it fails because spring-boot-maven-plugin 2.5.0-SNAPSHOT needs spring-core 5.3.5-SNAPSHOT. But that artifact is not in the Spring Boot projects..?

@Jurrie Jurrie marked this pull request as ready for review March 10, 2021 13:26
@Jurrie Jurrie changed the title Revert commit c4a55a5fb4: enable reproducable builds for WAR repackaging Issue #25563: Revert commit c4a55a5fb4: enable reproducable builds for WAR repackaging Mar 10, 2021
@scottfrederick scottfrederick changed the title Issue #25563: Revert commit c4a55a5fb4: enable reproducable builds for WAR repackaging Support Maven's reproducible build feature for war repackaging Mar 10, 2021
@scottfrederick scottfrederick added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Mar 10, 2021
@scottfrederick scottfrederick added this to the 2.x milestone Mar 10, 2021
@wilkinsona
Copy link
Member

it fails because spring-boot-maven-plugin 2.5.0-SNAPSHOT needs spring-core 5.3.5-SNAPSHOT. But that artifact is not in the Spring Boot projects..?

That's correct. spring-core is part of Spring Framework. All Spring project snapshots are published to https://repo.spring.io/snapshot.

@wilkinsona wilkinsona self-assigned this Mar 11, 2021
@wilkinsona wilkinsona modified the milestones: 2.x, 2.5.0-M3 Mar 11, 2021
@wilkinsona
Copy link
Member

Thanks very much for making your first contribution to Spring Boot, @Jurrie.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants