Skip to content

Conversation

@izeye
Copy link
Contributor

@izeye izeye commented Jan 18, 2021

PersistenceExceptionTranslationAutoConfigurationTests.persistOfNullThrowsIllegalArgumentExceptionWithoutExceptionTranslation() has been ignored in 59d2b0a somehow. I'm not sure if it was intentional, but it seems to pass for now. This PR simply restores it.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 18, 2021
@snicoll
Copy link
Member

snicoll commented Jan 18, 2021

I'm not sure if it was intentional

Given how it has been commented out, I suspect this was a temporary measure that got pushed by accident. Thanks again for spotting that @izeye!

@snicoll snicoll added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged labels Jan 18, 2021
@snicoll snicoll self-assigned this Jan 18, 2021
@snicoll snicoll added this to the 2.5.0-M1 milestone Jan 18, 2021
snicoll pushed a commit that referenced this pull request Jan 18, 2021
snicoll added a commit that referenced this pull request Jan 18, 2021
@snicoll snicoll closed this in e0a3b79 Jan 18, 2021
@izeye izeye deleted the restore-test branch January 18, 2021 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: task A general task

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants