Skip to content
Closed

Polish #24558

Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -108,16 +108,17 @@ public static MeterValue valueOf(long value) {
* Return a new {@link MeterValue} instance for the given double value.
* @param value the source value
* @return a {@link MeterValue} instance
* @since 2.3.0
*/
public static MeterValue valueOf(double value) {
return new MeterValue(value);
}

private static Double safeParseDouble(String value) {
try {
return Double.parseDouble(value);
return Double.valueOf(value);
}
catch (NumberFormatException nfe) {
catch (NumberFormatException ex) {
return null;
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,8 @@ void getValueForDistributionSummaryWhenFromNumberShouldReturnDoubleValue() {

@Test
void getValueForDistributionSummaryWhenFromNumberStringShouldReturnDoubleValue() {
MeterValue meterValue = MeterValue.valueOf("123");
assertThat(meterValue.getValue(Type.DISTRIBUTION_SUMMARY)).isEqualTo(123);
MeterValue meterValue = MeterValue.valueOf("123.42");
assertThat(meterValue.getValue(Type.DISTRIBUTION_SUMMARY)).isEqualTo(123.42);
}

@Test
Expand Down