Skip to content

Add preliminary support for JDK 16 #24453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Add preliminary support for JDK 16 #24453

wants to merge 2 commits into from

Conversation

@dreis2211
Copy link
Contributor

@dreis2211 dreis2211 commented Dec 10, 2020

Hi,

this PR is a first step into supporting JDK 16 (see #24402 ), which can be tested when setting the custom buildJavaHome property (at least build 16.ea.27 is needed to have Stream.toList() available). For everything else in #24402 we need Gradle with JDK 16 support.

Cheers,
Christoph

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Dec 10, 2020
snicoll added a commit that referenced this pull request Dec 21, 2020
@snicoll
Fix multi-release JAR test on JDK 16
306b964 
See gh-24453
@snicoll snicoll self-assigned this Dec 21, 2020
@snicoll snicoll added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged labels Dec 21, 2020
@snicoll snicoll added this to the 2.4.2 milestone Dec 21, 2020
snicoll pushed a commit that referenced this pull request Dec 21, 2020
@dreis2211 @snicoll
Add JavaVersion entry for JDK 16
f9fbadb 
See gh-24453
@snicoll snicoll mentioned this pull request Dec 21, 2020
Closed
@snicoll snicoll closed this in cd9e8a8 Dec 21, 2020
@snicoll
Copy link
Member

snicoll commented Dec 21, 2020

Thanks @dreis2211. I've backported the fix for the test in 2.3.x and updated JavaVersion for 2.4.x onwards. While I'd like us to be able to build Spring Boot 2.3.x with Java 16, an official support of it is only available as of Spring Framework 5.3 so introducing the enum in that version sends the wrong message IMO.

@dreis2211
Copy link
Contributor Author

dreis2211 commented Dec 21, 2020

@snicoll Agree about the enum

@wilkinsona wilkinsona mentioned this pull request Mar 8, 2021
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@snicoll snicoll

Labels

type: task A general task

Projects

None yet

Milestone

2.4.2

Development

Successfully merging this pull request may close these issues.

3 participants

@dreis2211 @snicoll @spring-projects-issues