Allow DurationFormat and PeriodFormat to be used on parameters #22646
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
wilkinsona
requested changes
Jul 29, 2020
Comment on lines
796
to
797
| assertThat(bean.getFormattedDuration()).isEqualTo(Duration.ofDays(15)); | ||
| assertThat(bean.getFormattedPeriod()).isEqualTo(Period.ofYears(16)); |
There was a problem hiding this comment.
These assertions succeed without @DurationFormat and @PeriodFormat on ConstructorParameterWithUnitProperties. I think that's because the converter successfully infers the style to use from the value that's being converted. To verify that the format annotations are working as expected, I think it would be necessary to trigger a failure by trying, for example, to bind an ISO-8601 value to a property that requires the simple style.
There was a problem hiding this comment.
I extended/reworked the testing a bit. Let me know if this is what you had in mind, @wilkinsona
wilkinsona
added
type: enhancement
wilkinsona
approved these changes
Jul 30, 2020
wilkinsona
pushed a commit
that referenced
this pull request
Jul 30, 2020
wilkinsona
added a commit
that referenced
this pull request
Jul 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this PR should close #22644 .
Cheers,
Christoph