Add Gradle Enterprise Maven Extension #22089
Closed
+69
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@runningcode Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
spring-projects-issues
added
the
status: waiting-for-triage
This adds build caching and build scans. The changes required disabling scans when using the maven invoker plugin in order to not cause duplicate build scans when invoking other maven builds. There is also an empty `.mvn` folder in the spring-boot-starters project to prevent duplicate build scans as well since there is no way to pass properties to the maven-javadoc-plugin. The checkstyle plugin was causing a cache miss with the `propertyExpansion` because it contains an absolute path. The absolute path is now ignored and instead the files are added as inputs to the checkstyle plugin. This only enables the local build cache. The remote cache is not yet enabled. On my local machine: ./mvnw clean install build times go from about 30 minutes to about 10 minutes. ./mvnw clean install -Pfull build times go from about 60 minutes to about 13 minutes.
runningcode
force-pushed
the
no/2.1.x/maven-enterprise
branch
from
261cbb8 to
57399e6
Compare
|
@runningcode Thank you for signing the Contributor License Agreement! |
wilkinsona
added
type: task
Member
|
Thanks very much for the PR, @runningcode. This is currently blocked on spring-io/develocity-conventions#8. |
Member
|
0.0.5 of the extension is now on Maven Central so this is no longer blocked. |
wilkinsona
removed
the
status: blocked
Contributor
Author
|
@wilkinsona I've updated this PR to use 0.0.5 of the Spring |
wilkinsona
pushed a commit
that referenced
this pull request
Jul 24, 2020
This adds build caching and build scans. The changes required disabling scans when using the maven invoker plugin in order to not cause duplicate build scans when invoking other maven builds. There is also an empty `.mvn` folder in the spring-boot-starters project to prevent duplicate build scans as well since there is no way to pass properties to the maven-javadoc-plugin. The checkstyle plugin was causing a cache miss with the `propertyExpansion` because it contains an absolute path. The absolute path is now ignored and instead the files are added as inputs to the checkstyle plugin. This only enables the local build cache. The remote cache is not yet enabled. On my local machine: ./mvnw clean install build times go from about 30 minutes to about 10 minutes. ./mvnw clean install -Pfull build times go from about 60 minutes to about 13 minutes. See gh-22089
wilkinsona
added a commit
that referenced
this pull request
Jul 24, 2020
wilkinsona
changed the title
Member
|
Thanks very much, @runningcode. This has been merged into 2.1.x and forwards in 2.2.x. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds build caching and build scans.
The changes required disabling scans when using the maven invoker plugin in order to not cause duplicate build scans when invoking other maven builds.
There is also an empty
.mvnfolder in the spring-boot-starters project to prevent duplicate build scans as well since there is no way to pass properties to the maven-javadoc-plugin.The checkstyle plugin was causing a cache miss with the
propertyExpansionbecause it contains an absolute path. The absolute path is now ignored and instead the files are added as inputs to the checkstyle plugin.This only enables the local build cache. The remote cache is not yet enabled.
On my local machine:
./mvnw clean installbuild times go from about 30 minutes to about 10 minutes../mvnw clean install -Pfullbuild times go from about 60 minutes to about 13 minutes.