Management health group does not inherit show-details property #22022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
bclozel
added
type: bug
philwebb
pushed a commit
that referenced
this pull request
Jun 23, 2020
Update `Group` properties so that the `showDetails` value does not inherit `Show.NEVER`. Prior to this commit, the `Group` properties would not correctly inherit a `showDetails` value from the main `management.endpoint.health.show-details` property. See gh-22022
philwebb
added a commit
that referenced
this pull request
Jun 23, 2020
Rework the inheritance so that the property metadata JSON more accurately reflects the default value. See gh-22022
|
Thanks very much for the PR @polarbear567, this has now been merged to 2.2.x, 2.3.x and master. I made one small tweak in commit e6eb026 which should helpfully provide correct JSON metadata for IDEs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.