Skip to content

Conversation

dreis2211
Copy link
Contributor

Hi,

this PR upgrades to Testcontainers 1.14.1.

Cheers,
Christoph

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label May 10, 2020
@snicoll
Copy link
Member

snicoll commented May 12, 2020

We are still discussing whether we want to accept certain "only version" upgrades PR, see #20707. I am going to put this one on-hold until we get a chance to finalize this discussion.

@snicoll snicoll added the status: on-hold We can't start working on this issue yet label May 12, 2020
@dreis2211
Copy link
Contributor Author

Sure thing. I kept myself quite for a bit as the version was released two weeks ago already, I think. If that contributes to the discussion a bit.

@philwebb
Copy link
Member

We should upgrade this anyway, regardless of #20707. I'm not sure if BOMR will pick it up so I'll drop it in 2.3.0 just so we don't forget.

@philwebb philwebb added this to the 2.3.0 milestone May 12, 2020
@philwebb philwebb added type: dependency-upgrade A dependency upgrade and removed status: waiting-for-triage An issue we've not yet triaged labels May 12, 2020
@dreis2211
Copy link
Contributor Author

dreis2211 commented May 12, 2020

Bomr won't pick it up. That's part of the discussion: if one-liner upgrades should be rejected even though they're not picked up by bomr (which is essentially only stuff in spring-boot-dependencies)

@snicoll snicoll removed the status: on-hold We can't start working on this issue yet label May 13, 2020
@snicoll snicoll self-assigned this May 13, 2020
snicoll pushed a commit that referenced this pull request May 13, 2020
@snicoll snicoll closed this in a09ef94 May 13, 2020
@snicoll
Copy link
Member

snicoll commented May 13, 2020

Thanks for that @dreis2211.

I kept myself quite for a bit as the version was released two weeks ago already, I think.

As I've indicated in this comment, it is less important/urgent to upgrade an internally managed dependency. We do so when we could benefit from a new feature or the dependency fixed an issue we're facing. Otherwise, such upgrade happens in due course as part of a general chore similar to how we apply bomr upgrades.

@dreis2211
Copy link
Contributor Author

I think the perfect solution is teaching Bomr to handle internal dependencies, too - as suggested in #21439 . That avoids manual work 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: dependency-upgrade A dependency upgrade
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants