Favor exec-maven-plugin shorthand property over redefinition #20690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this change, users can now rely on the standard `exec.mainClass` property when executing the exec-maven-plugin. Users of the `start-class` property are unaffected. Thanks @hboutemy for the initial diagnosis and suggestion for the fix.
spring-projects-issues
added
the
status: waiting-for-triage
|
For more context, I am writing a helper for projectriff streaming processor. While the project uses Spring Boot, the helper is completely standalone and it took me a long time to understand that Spring Boot parent POM actually rewrites the While this issue is far from new, it seems it surprised a few more people, judging by the votes on StackOverflow. |
philwebb
added
the
for: team-attention
philwebb
removed
the
for: team-attention
|
Thank you for the additional context. We've discussed this one and decided to remove plugin management for the exec plugin altogether. I've created #20883 |
snicoll
added
status: declined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, users can now rely on the standard
exec.mainClassproperty when executing the exec-maven-plugin.Users of the
start-classproperty are unaffected.Thanks @hboutemy for the initial diagnosis and suggestion for the
fix.