Skip to content

Conversation

scheerer
Copy link
Contributor

@scheerer scheerer commented Feb 6, 2020

When trying to use the maven-shade-plugin plugin in a project using the latest 2.3.0.M1 milestone release we encounter this error:

[ERROR] [ERROR] Some problems were encountered while processing the POMs:
[ERROR] 'build.plugins.plugin[org.apache.maven.plugins:maven-shade-plugin].dependencies.dependency.version' for org.springframework.boot:spring-boot-maven-plugin:jar must be a valid version but is '${revision}'. @ org.springframework.boot:spring-boot-starter-parent:2.3.0.M1, /Users/demo/.m2/repository/org/springframework/boot/spring-boot-starter-parent/2.3.0.M1/spring-boot-starter-parent-2.3.0.M1.pom, line 211, column 24

Build Settings:

<build>
    <plugins>
        <plugin>
            <groupId>org.apache.maven.plugins</groupId>
            <artifactId>maven-shade-plugin</artifactId>
            <configuration>
                <createDependencyReducedPom>false</createDependencyReducedPom>
            </configuration>
            <executions>
                <execution>
                    <phase>package</phase>
                    <goals>
                        <goal>shade</goal>
                    </goals>
                </execution>
            </executions>
        </plugin>
    </plugins>
</build>

I believe this PR fixes what seems to be a very slight oversight during the Gradle migration.

@pivotal-issuemaster
Copy link

@scheerer Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-issuemaster
Copy link

@scheerer Thank you for signing the Contributor License Agreement!

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 6, 2020
@scheerer scheerer changed the title Fixing incorrect variable reference after Maven->Gradle migration Fixing incorrect variable reference to ${revision} after Maven->Gradle migration Feb 6, 2020
@snicoll snicoll added type: regression A regression from a previous release and removed status: waiting-for-triage An issue we've not yet triaged labels Feb 6, 2020
@snicoll snicoll self-assigned this Feb 6, 2020
@snicoll snicoll added this to the 2.3.0.M2 milestone Feb 6, 2020
@snicoll snicoll changed the title Fixing incorrect variable reference to ${revision} after Maven->Gradle migration Invalid variable reference in maven-shade-plugin configuration Feb 6, 2020
@snicoll snicoll closed this in 0083a59 Feb 6, 2020
@snicoll
Copy link
Member

snicoll commented Feb 6, 2020

@scheerer good catch! Thank you for making your first contribution to Spring Boot.

@scheerer scheerer deleted the bugfix/fix_shade_plugin branch February 12, 2020 14:06
@wilkinsona wilkinsona added the status: superseded An issue that has been superseded by another label Feb 12, 2020
@wilkinsona wilkinsona removed this from the 2.3.0.M2 milestone Feb 12, 2020
@wilkinsona
Copy link
Member

Superseded by #20143.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: superseded An issue that has been superseded by another type: regression A regression from a previous release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants