Requests are auto-timed when autotime.enabled is set to false #19981
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@babjo Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@babjo Thank you for signing the Contributor License Agreement! |
spring-projects-issues
added
the
status: waiting-for-triage
wilkinsona
changed the title
wilkinsona
added
type: bug
|
Turns out this one works in 2.1 already. Seems like a regression introduced with #17026 |
snicoll
pushed a commit
that referenced
this pull request
Feb 4, 2020
snicoll
added a commit
that referenced
this pull request
Feb 4, 2020
|
@babjo thank you for making your first contribution to Spring Boot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
According to this doc, it says
Alternatively, when set to false, you can enable instrumentation by adding @Timed to a request-handling method. However our current actuator doesn't recognize themanagement.metrics.web.server.request.autotime.enabled's value inrecord(timingContext, request, response, exception)ofWebMvcMetricsFilter.javaand the actuator's metric doesn't work properly.Changes
this.autoTimer.isEnabled()References