Skip to content

Allow Data Couchbase's type key to be configured via application properties #19789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Allow Data Couchbase's type key to be configured via application properties #19789

wants to merge 1 commit into from

Conversation

@grudir
Copy link

@grudir grudir commented Jan 17, 2020

Provide the ability to customize Couchbase Data type key.

@pivotal-issuemaster
Copy link

@grudir Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 17, 2020
wilkinsona
wilkinsona requested changes Jan 17, 2020
View reviewed changes
Copy link
Member

@wilkinsona wilkinsona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for the PR. I've left a couple of comments. If you have time, could you please take a look and, if you agree with the suggestions, update your changes accordingly?

...boot-autoconfigure/src/main/resources/META-INF/additional-spring-configuration-metadata.json Outdated
Comment on lines 351 to 355
{
"name": "spring.data.couchbase.type-key",
"description": "Property key used by Couchbase as the document type.",
"defaultValue": "_class"
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no need for additional metadata here. It will be automatically generated from the new field on CouchbaseDataProperties

...main/java/org/springframework/boot/autoconfigure/data/couchbase/CouchbaseDataProperties.java
Comment on lines 43 to 46
/**
* The type key to use if a complex type was identified.
*/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be good if this description was similar to the javadoc for typeKey(). Perhaps something like the following:

Name of the field that will store the type information for complex types when using MappingCouchbaseConverter

@pivotal-issuemaster
Copy link

@grudir Thank you for signing the Contributor License Agreement!

@grudir
Copy link
Author

grudir commented Jan 17, 2020

@wilkinsona thank you for the lightning fast review and feedback! Comments are addressed.

@grudir grudir requested a review from wilkinsona January 17, 2020 15:41
@grudir grudir force-pushed the couchbase-data-custom-type-key branch from c6d0ca1 to 1c11556 Compare January 17, 2020 20:18
@wilkinsona wilkinsona added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Jan 17, 2020
@wilkinsona wilkinsona changed the title Custom Couchbase Data Type Key Allow Data Couchbase's type key to be configured via application properties Jan 17, 2020
@wilkinsona wilkinsona added this to the 2.3.x milestone Jan 17, 2020
@grudir
Copy link
Author

grudir commented Jan 17, 2020

@wilkinsona I missed that master goes to next minor release, which happens to be 2.3.x. I'd like to include this feature in next 2.2.x release. I'll close this PR and open a new one to branch 2.2.x. Thank you for the support!

@wilkinsona
Copy link
Member

@grudir We don’t add new features in maintenance releases I’m afraid. Please keep this PR open and we’ll hopefully include it 2.3.

@snicoll snicoll self-assigned this Jan 27, 2020
@snicoll snicoll modified the milestones: 2.3.x, 2.3.0.M2 Jan 27, 2020
snicoll pushed a commit that referenced this pull request Jan 27, 2020
@snicoll
Add support for Spring Data Couchbase custom type key
d1a44df 
See gh-19789
snicoll added a commit that referenced this pull request Jan 27, 2020
@snicoll
Polish "Add support for Spring Data Couchbase custom type key"
af4fdf0 
See gh-19789
@snicoll snicoll closed this in ebcb2ac Jan 27, 2020
@snicoll
Copy link
Member

snicoll commented Jan 27, 2020

@grudir thank you for making your first contribution to Spring Boot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wilkinsona wilkinsona wilkinsona approved these changes

Assignees

@snicoll snicoll

Labels

type: enhancement A general enhancement

Projects

None yet

Milestone

2.3.0.M2

Development

Successfully merging this pull request may close these issues.

5 participants

@grudir @pivotal-issuemaster @wilkinsona @snicoll @spring-projects-issues