Skip to content

Harmonize settings.gradle documentation in Gradle getting started guide #17736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Harmonize settings.gradle documentation in Gradle getting started guide #17736

wants to merge 1 commit into from

Conversation

dsyer
Copy link
Member

@dsyer dsyer commented Jul 30, 2019

This works better (copied from start.spring.io). Otherwise there might be plugins that cannot be resolved.

Add missing repositories to snapshot configuration
2978d3b 
This works better (copied from start.spring.io). Otherwise there might be plugins that cannot be resolved.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jul 30, 2019
@philwebb philwebb added type: documentation A documentation update and removed status: waiting-for-triage An issue we've not yet triaged labels Jul 30, 2019
@philwebb philwebb added this to the 2.1.x milestone Jul 30, 2019
@snicoll
Copy link
Member

snicoll commented Jul 31, 2019

@dsyer this confused me more than once but libs-snapshot contains more than just snapshots. For instance, you can see snapshots, milestones and releases of the Spring Boot Gradle plugin. I guess the gradlePluginPortal is what that matters here.

On the other hand, we should probably align to whatever start.spring.io does but I just want to make sure I am not missing some context.

@snicoll snicoll added the status: waiting-for-feedback We need additional information before we can continue label Jul 31, 2019
@dsyer
Copy link
Member Author

dsyer commented Jul 31, 2019

I just copied from start.spring.io. If you want to change it there as well, fine by me. I don't think you are missing anything.

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Jul 31, 2019
@snicoll
Copy link
Member

snicoll commented Jul 31, 2019 •
edited
Loading

There are four impacted files in this directory. Milestone and snapshots as well as a Groovy DSL and a Kotlin DSL version. Let's align them to whatever start.spring.io does.

@snicoll snicoll changed the title Add missing repositories to snapshot configuration Harmonize settings.gradle documentation in Gradle getting started guide Jul 31, 2019
snicoll pushed a commit that referenced this pull request Jul 31, 2019
@snicoll
Add missing repositories to snapshot configuration
e7b0450 
See gh-17736
snicoll added a commit that referenced this pull request Jul 31, 2019
@snicoll
Harmonize settings.gradle documentation in Gradle getting started guide
0c56079 
See gh-17736
@snicoll snicoll mentioned this pull request Jul 31, 2019
Closed
@snicoll snicoll self-assigned this Jul 31, 2019
@snicoll snicoll modified the milestones: 2.1.x, 2.1.7 Jul 31, 2019
@snicoll snicoll closed this in 340a205 Jul 31, 2019
@snicoll snicoll deleted the dsyer-patch-1 branch August 1, 2019 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@snicoll snicoll

Labels
status: feedback-provided Feedback has been provided type: documentation A documentation update
Projects
None yet
Milestone
2.1.7
Development

Successfully merging this pull request may close these issues.
4 participants
@dsyer @snicoll @philwebb @spring-projects-issues