Remove testsupport.assertj package #17557
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
dreis2211
commented
Jul 17, 2019
| factory.clearCache(); | ||
| MetadataReader metadataReader2 = factory.getMetadataReader(getClass().getName()); | ||
| assertThat(metadataReader1).isNotEqualTo(sameInstance(metadataReader2)); | ||
| assertThat(metadataReader1).isNotSameAs(metadataReader2); |
There was a problem hiding this comment.
Hope that slightly related polishing is okay here.
wilkinsona
added
type: task
snicoll
pushed a commit
that referenced
this pull request
Jul 18, 2019
|
Thanks again Christoph. No problem for the slightly related polish |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this PR replaces usages of
org.springframework.boot.testsupport.assertj.Matchedwith native AssertJ calls and removes the therefore unused class/package. Plus some related polishing.Let me know what you think.
Cheers,
Christoph