Skip to content

Conversation

marcrohlfs
Copy link
Contributor

We need to change the packaging layout in some special cases (in CI builds) and don't want to clutter or production code adding overwritable properties to our POMs - furthermore we'd have to define a default that would disable the standard behavior of layout auto-detection.

With this PR the layout parameter of the repackage goal can be set from the
command line, using the system property spring-boot.repackage.layout.

Allow the _layout_ parameter of the _repackage_ goal to be set from the
command line, using the system property `spring-boot.repackage.layout`.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jun 20, 2019
@philwebb philwebb added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Jun 20, 2019
@philwebb philwebb added this to the 2.2.x milestone Jun 20, 2019
@snicoll
Copy link
Member

snicoll commented Jun 21, 2019

) and don't want to clutter or production code adding overwritable properties to our POMs - furthermore we'd have to define a default that would disable the standard behavior of layout auto-detection.

@marcrohlfs regardless of the proposal here I'd like to understand what you mean by that. If you want to change the layout you can define a different plugin configuration in a profile and enable that profile on the command line with -P. What is wrong with that?

@snicoll snicoll added the status: waiting-for-feedback We need additional information before we can continue label Jun 21, 2019
@marcrohlfs
Copy link
Contributor Author

@snicoll Normally You're right, but in our setup (with multiple applications not "attached" to the same Maven parent), it's barely possible to define (a profile with) a common plugin management. Furthermore we're solving an internal case on public code/setup with this, hence we rather don't want to have this extra configuration in the public POM.

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Jun 21, 2019
@snicoll snicoll self-assigned this Jul 18, 2019
@snicoll snicoll removed the status: feedback-provided Feedback has been provided label Jul 18, 2019
@snicoll
Copy link
Member

snicoll commented Jul 18, 2019

Fair enough, thanks for the feedback @marcrohlfs

@snicoll snicoll changed the title Make layout parameter settable via property Make layout parameter available as a user property Jul 18, 2019
snicoll pushed a commit that referenced this pull request Jul 18, 2019
This commit allows the layout parameter of the Maven repackage goal to
be set from the command line.

See gh-17277
@snicoll snicoll closed this in b092cb7 Jul 18, 2019
@snicoll snicoll modified the milestones: 2.2.x, 2.2.0.M5 Jul 18, 2019
@snicoll
Copy link
Member

snicoll commented Jul 18, 2019

@marcrohlfs thank you for making your first contribution to Spring Boot. This is now merged in master.

@marcrohlfs
Copy link
Contributor Author

@snicoll You're welcome. And many thanks fo accepting and merging 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants