Skip to content

Conversation

ielatif
Copy link
Contributor

@ielatif ielatif commented Jun 5, 2019

This commit rectifies and improves existing javadoc of management server port.
Closes #17054

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jun 5, 2019
@mbhave mbhave added type: documentation A documentation update and removed status: waiting-for-triage An issue we've not yet triaged labels Jun 5, 2019
@mbhave mbhave added this to the 1.5.x milestone Jun 5, 2019
@ielatif
Copy link
Contributor Author

ielatif commented Jun 5, 2019

@mbhave the PR is raised against 2.1.x milestone. Do you want it to be backported to 1.5.x?

@philwebb
Copy link
Member

@ielatif Thanks for the offer but there's no need. We'll just cherry-pick the commit.

This commit rectifies and improves existing javadoc of management server port.
Closes spring-projects#17054
@ielatif
Copy link
Contributor Author

ielatif commented Jun 10, 2019

@philwebb thanks. Fixed checkstyle violations can you please rerun CI build?

@philwebb
Copy link
Member

@ielatif The build is pending, it should build in a bit.

@ielatif
Copy link
Contributor Author

ielatif commented Jun 11, 2019

@philwebb thanks, CI build is successful now

snicoll pushed a commit that referenced this pull request Jun 19, 2019
@snicoll snicoll self-assigned this Jun 19, 2019
@snicoll snicoll modified the milestones: 1.5.x, 1.5.22 Jun 19, 2019
@snicoll snicoll closed this in 29de792 Jun 19, 2019
@ielatif ielatif deleted the gh-17054 branch June 19, 2019 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation A documentation update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rectify javadoc for disabling management server port
5 participants