Fix NoClassDefFoundError when Spring Session is used without Spring Security #16889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit ensures auto-configuration of Spring Session's DefaultCookieSerializer doesn't break when Spring Security is not present on the classpath.
spring-projects-issues
added
the
status: waiting-for-triage
philwebb
added
for: merge-with-amendments
|
We might get away with getting the bean programmatically rather than needing the |
snicoll
changed the title
philwebb
added a commit
that referenced
this pull request
May 28, 2019
philwebb
added a commit
that referenced
this pull request
May 28, 2019
* pr/16889: Polish "Fix NoClassDefFound when missing Spring Security" Fix NoClassDefFound when missing Spring Security
|
Thanks @vpavic, now fixed with a small change to remove the need for the BPP. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #16871 by ensuring auto-configuration of Spring Session's DefaultCookieSerializer doesn't break when Spring Security is not present on the classpath.
The approach taken in this PR uses an anonymous
BeanPostProcessor- I'm not sure this is an acceptable approach but introducing some sort of a customizer bean seemed like an overhead inDefaultCookieSerializercase.Regarding the anonymous
BeanPostProcessorpattern, it is also present inLiquibaseEndpointAutoConfiguration.