Skip to content

Conversation

garyrussell
Copy link
Contributor

Resolves #16727

Requires #16739

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label May 7, 2019
@wilkinsona wilkinsona changed the title GH-16727: Kafka missingTopicsFatal property Provide a configuration property for Spring Kafka's missingTopicsFatal May 9, 2019
@wilkinsona wilkinsona added this to the 2.2.x milestone May 9, 2019
@wilkinsona wilkinsona added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels May 9, 2019
@snicoll snicoll self-assigned this May 20, 2019
@snicoll snicoll modified the milestones: 2.2.x, 2.2.0.M4 May 20, 2019
@snicoll snicoll closed this in 3c46b9e May 20, 2019
snicoll added a commit that referenced this pull request May 20, 2019
* pr/16740:
  Polish "Add configuration property for Spring Kafka's missingTopicsFatal"
  Add configuration property for Spring Kafka's missingTopicsFatal
@snicoll
Copy link
Member

snicoll commented May 20, 2019

@garyrussell thank you for the PR and sorry we didn't manage to merge that for M3. I've polished and changed the type to boolean as this property has an obvious default to Spring Kafka. I've added a test to check that our defaults match yours. We should probably review the list and swap other properties at some point, see 3c46b9e

@garyrussell garyrussell deleted the GH-16727 branch May 20, 2019 14:05
@garyrussell
Copy link
Contributor Author

Sounds good; thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add KafkaProperty for configuring ContainerProperties. missingTopicsFatal
4 participants